When I changed my shocks, I overtightened the nut that holds the upper spring cup on, which crushed the tiny circlip that sits in the groove on the rod.This meant that the shock wasn't moving when the spring compressed, and it was knocking like a bastard- took me ages to work out what it was!